Add --print host-tuple to print host target tuple
#125579
Conversation
Noratrieb
added
the
needs-fcp
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
I would prefer |
Cargo also does this. |
|
@rfcbot merge |
|
Team member @oli-obk has proposed to merge this. The next step is review by the rest of the tagged team members:
Concerns:
Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
|
@rfcbot concern triple vs tuple |
|
As a data point, our existing documentation seem to call it "triple" pretty consistently: |
This comment was marked as resolved.
This comment was marked as resolved.
|
So, should that be "tuple" or "triple"? (trying to understand if the concern raised is still standing) |
|
I personally don't have a strong opinion here and would be open to rescind my concern
https://doc.rust-lang.org/rustc/platform-support/loongarch-linux.html?highlight=tuple#loongarch-unknown-linux- already uses tuple @michaelwoerister @workingjubilee does one of you care strongly about either option? It is fairly arbitrary in the end (and its documentation should probably mention the alternative). One simple way to resolve this might just be a vote on zulip and we pick whatever ends up on top as long as nobody feels very strongly about this: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/.60--print.20host.5B-tuple.7C-triple.5D.60 |
|
I voted "don't care" on Zulip. |
|
r? compiler |
|
I don't think there's necessarily a strong consensus from the Zulip poll on terminology here, the team seems to have a slight preference towards |
rustbot
added
A-compiletest
|
Some changes occurred in src/tools/opt-dist cc @Kobzol These commits modify compiler targets. Some changes occurred in src/tools/compiletest cc @jieyouxu Some changes occurred in cfg and check-cfg configuration cc @Urgau |
|
@davidtwco I do! I changed it to |
This comment has been minimized.
This comment has been minimized.
|
rebased at Nora's request |
|
mrow thanks |
bors
added
S-waiting-on-bors
Add `--print host-tuple` to print host target tuple People often parse `-vV` output to get to the host tuple, which is annoying to do. It's easier to just get it directly. I called it "host-tuple" instead of "host" because it's clearer that it's just the target name. I'm open to different names, but I think this one is fine. a quick GitHub search for `'^host` reveals many instances of people doing the parsing, for example: https://github.com/japaric/xargo/blob/68e0ca57cd90837fe02f262f074182f9cfeb6227/README.md?plain=1#L369 https://github.com/taiki-e/setup-cross-toolchain-action/blob/0e38473b0c562d6db19a98d3ec20a80f7ac189ae/main.sh#L96 https://github.com/taiki-e/cargo-llvm-cov/blob/8a3553b86551eabf9c30c060b1f72a5bbccb98c6/README.md?plain=1#L625 https://github.com/SiliconLabs/cpc-nvm3/blob/43f3ec39709b30700ef7f39d91fa647974323bf1/do.sh#L35 needs a compiler FCP. I could also do an MCP but I think just an FCP here makes the most sense.
This comment has been minimized.
This comment has been minimized.
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
This changes the naming to the new naming, used by `--print target-tuple`. It does not change all locations, but many.
People often parse `-vV` output to get to the host triple, which is annoying to do. It's easier to just get it directly.
|
fixed a trivial semantic conflict where a stray test file was around |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (8ccb78e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is the most reliable metric that we have; it was used to determine the overall result at the top of this comment. However, even this metric can sometimes exhibit noise.
Max RSS (memory usage)Results (primary -2.5%, secondary -4.1%)This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 781.635s -> 779.462s (-0.28%) |
People often parse
-vVoutput to get to the host tuple, which is annoying to do. It's easier to just get it directly.I called it "host-tuple" instead of "host" because it's clearer that it's just the target name. I'm open to different names, but I think this one is fine.
a quick GitHub search for
'^hostreveals many instances of people doing the parsing, for example:https://github.com/japaric/xargo/blob/68e0ca57cd90837fe02f262f074182f9cfeb6227/README.md?plain=1#L369
https://github.com/taiki-e/setup-cross-toolchain-action/blob/0e38473b0c562d6db19a98d3ec20a80f7ac189ae/main.sh#L96
https://github.com/taiki-e/cargo-llvm-cov/blob/8a3553b86551eabf9c30c060b1f72a5bbccb98c6/README.md?plain=1#L625
https://github.com/SiliconLabs/cpc-nvm3/blob/43f3ec39709b30700ef7f39d91fa647974323bf1/do.sh#L35
needs a compiler FCP. I could also do an MCP but I think just an FCP here makes the most sense.